Add abitility to set QPS and Burst limits for api client#2667
Add abitility to set QPS and Burst limits for api client#2667FxKu merged 14 commits intozalando:masterfrom
Conversation
|
Any updates ? |
|
Can you not make these variables also configurable similar to NoDatabaseAccess and NoTeamsAPI. We can use 5 and 10 as default values. |
|
@FxKu I have reverted my previous changes because we can't change qps and burst limits for kube client after initialization. |
|
Config changes always require a replacement of the operator pod. Doesn't this initialize the client as well each time? |
|
@FxKu I mean that you can't change kubernetes client parameters after client has been initilized. |
|
@FxKu We have been testing this fix in our k8s cluster with 200+ postgres clusters for 2 weeks now and it really helps. |
|
@FxKu any updates? |
Can you add a chapter in the docs on how to do this (administrator.md is a good place, I think)? I guess many users would be interested. |
|
@Demch1k PR is now green after I have increased the qps and burst value slightly. Could you provide a small paragraph to our docs to show how people can scale the operator so it can handle 200+ clusters. This would be much appreciated. I can then merge it tomorrow so it will be included in the release. |
|
👍 |
|
@FxKu Sorry, I was totally running of time. Hope will have time soon |
|
👍 |
|
Thanks @Demch1k. We merge it now, but a follow PR would be welcome. |
|
Hi @Demch1k, thanks for the improvement — this seems very useful. A couple of questions:
|
…elm values This change introduces the ability to specify additional command-line arguments for the Postgres Operator via the "extraArgs" field in values.yaml. Documentation has been updated with details on new arguments "-kubeqps" and "-kubeburst" added before: zalando#2667. The chart version is bumped to 1.14.1 to reflect these changes.
We have a problem in our big kubernetes clusters with 300+ postgres clusters.
When operator starts reconcile it can stack creating new clusters for 10-15 minutes and We can see in the logs messages like that:
Especially in working hours when our developers create new environments.
This PR adds ability to set kubernetes qps and burst limits for client.