Skip to content

Give LinkTest and TagTest the same generous HTTP timeout as AbstractBaseTest#152

Merged
derpixler merged 1 commit into
masterfrom
fix/link-tag-test-timeout
Jul 16, 2026
Merged

Give LinkTest and TagTest the same generous HTTP timeout as AbstractBaseTest#152
derpixler merged 1 commit into
masterfrom
fix/link-tag-test-timeout

Conversation

@fliebe92

@fliebe92 fliebe92 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • LinkTest and TagTest create and delete real tickets (with articles, links, etc.) for every single test, but their setUpBeforeClass() predates EnvConfigTrait/AbstractBaseTest and never overrides the client's 5 second default HTTP timeout.
  • Under load, ticket deletion cascades through enough related records that it can occasionally exceed 5 seconds, causing a ConnectException in tearDown() that gets misattributed to whatever test happened to be running at the time (observed as e.g. LinkTest::testRemoveWithoutTargetTicket failing with a cURL timeout on a DELETE .../tickets/:id call, even though that test's own assertion doesn't touch the network at all).
  • AbstractBaseTest already fixed this for the test classes that extend it, by bumping the timeout to 30 seconds (configurable via ZAMMAD_PHP_API_CLIENT_UNIT_TESTS_TIMEOUT). This PR just brings LinkTest and TagTest in line with that existing convention.

Test plan

  • CI run of the full test suite should pass as before, just with a more generous timeout available for the create/delete-heavy LinkTest/TagTest fixtures.

…aseTest

Both classes create and delete real tickets (with articles, links, etc.) for
every single test, but still relied on the client's 5 second default HTTP
timeout instead of the 30 second one AbstractBaseTest already switched to.
Under load, ticket deletion cascades through enough related records that it
can occasionally exceed 5 seconds, causing a ConnectException in tearDown()
that gets misattributed to whatever test happened to be running.
@fliebe92
fliebe92 requested a review from derpixler July 16, 2026 06:48
@fliebe92 fliebe92 self-assigned this Jul 16, 2026
@derpixler
derpixler merged commit 4539f97 into master Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants