Give LinkTest and TagTest the same generous HTTP timeout as AbstractBaseTest#152
Merged
Conversation
…aseTest Both classes create and delete real tickets (with articles, links, etc.) for every single test, but still relied on the client's 5 second default HTTP timeout instead of the 30 second one AbstractBaseTest already switched to. Under load, ticket deletion cascades through enough related records that it can occasionally exceed 5 seconds, causing a ConnectException in tearDown() that gets misattributed to whatever test happened to be running.
derpixler
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkTestandTagTestcreate and delete real tickets (with articles, links, etc.) for every single test, but theirsetUpBeforeClass()predatesEnvConfigTrait/AbstractBaseTestand never overrides the client's 5 second default HTTP timeout.ConnectExceptionintearDown()that gets misattributed to whatever test happened to be running at the time (observed as e.g.LinkTest::testRemoveWithoutTargetTicketfailing with a cURL timeout on aDELETE .../tickets/:idcall, even though that test's own assertion doesn't touch the network at all).AbstractBaseTestalready fixed this for the test classes that extend it, by bumping the timeout to 30 seconds (configurable viaZAMMAD_PHP_API_CLIENT_UNIT_TESTS_TIMEOUT). This PR just bringsLinkTestandTagTestin line with that existing convention.Test plan
LinkTest/TagTestfixtures.