Skip to content

[codex] Add choose decimal dispatch regression test#74

Draft
zanmato1984 wants to merge 2 commits into
mainfrom
codex/choose-decimal-dispatch-test
Draft

[codex] Add choose decimal dispatch regression test#74
zanmato1984 wants to merge 2 commits into
mainfrom
codex/choose-decimal-dispatch-test

Conversation

@zanmato1984

Copy link
Copy Markdown
Owner

Summary

  • add a regression test for mixed decimal dispatch in choose
  • show that DispatchBest() currently leaves {decimal128(3, 2), decimal128(4, 3)} unnormalized

Why

The new test demonstrates that choose does not perform decimal common-type normalization in dispatch, unlike related functions such as if_else, case_when, and coalesce.

Validation

  • built arrow-compute-scalar-if-else-test in a fresh local CMake build tree
  • TestChooseKernel.DispatchBest: fails with the new assertion
  • TestChoose.Decimal: still passes

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant