[C++][Compute] Tighten coalesce exact dispatch for parameterized varargs#76
Draft
zanmato1984 wants to merge 1 commit into
Draft
[C++][Compute] Tighten coalesce exact dispatch for parameterized varargs#76zanmato1984 wants to merge 1 commit into
zanmato1984 wants to merge 1 commit into
Conversation
zanmato1984
force-pushed
the
codex/coalesce-exact-dispatch-decimal
branch
from
June 5, 2026 19:03
9d7ce60 to
4d81131
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coalesceexact dispatch for parameterized decimal varargs so mixed decimal precisions/scales fall through toDispatchBestduring expression bindingDispatchBestpathRoot cause
Expression binding tries
DispatchExactbeforeDispatchBest.coalesceregistered decimal varargs kernels with a broadInputType(Type::DECIMAL128/256)signature, so mixed parameterized decimals likedecimal128(3,2)anddecimal128(4,3)matched exactly during binding. That bypassed the decimal normalization inDispatchBest, leaving the bound expression without the implicit cast needed to a common decimal type.What changed
coalescevarargs kernels so exact dispatch requires identical parameterized decimal typesDispatchBest/DispatchExactand expression bindingTesting
debug/arrow-compute-expression-test --gtest_filter=Expression.BindWithImplicitCastsForCoalesceOnDecimaldebug/arrow-compute-scalar-if-else-test --gtest_filter=TestCoalesce.DispatchBest:TestCoalesce.DispatchExact