[codex] Preserve fast grouper key order#82
Draft
zanmato1984 wants to merge 8 commits into
Draft
Conversation
zanmato1984
force-pushed
the
codex/group-key-ordering-check
branch
from
July 14, 2026 20:06
d361b5f to
8297c7e
Compare
zanmato1984
changed the title
zanmato1984
force-pushed
the
codex/group-key-ordering-check
branch
from
July 14, 2026 20:31
949c8b7 to
4a448e0
Compare
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
zanmato1984
force-pushed
the
codex/group-key-ordering-check
branch
from
July 15, 2026 18:23
26b59fd to
2d893ae
Compare
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
zanmato1984
force-pushed
the
codex/group-key-ordering-check
branch
from
July 15, 2026 18:23
2d893ae to
98fb89e
Compare
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
Signed-off-by: Rossi Sun <zanmato1984@gmail.com>
zanmato1984
commented
Jul 20, 2026
Comment on lines
+590
to
+595
| if (num_inserted_ + num_pending_appends == num_groups_limit) { | ||
| // 中文说明：跳出当前 key 的 probing 循环，外层会保留剩余 selection。 | ||
| break; | ||
| } | ||
| // 中文说明：当前 key 已作为新 group 处理完，继续下一个 selection 项。 | ||
| break; |
Owner
Author
There was a problem hiding this comment.
这两个break不是重复了？上面的if没必要存在吧？
| // 中文说明：接收“不相等”的数量；0 表示当前 key 命中已有 group。 | ||
| int num_not_equal; | ||
| // 中文说明：只比较当前 row 和刚找到的候选 group。 | ||
| run_comparisons(1, &temp_id, nullptr, out_group_ids, &num_not_equal, &temp_id, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cmake --build .build-choose-test --target arrow-compute-row-test -j8.build-choose-test/release/arrow-compute-row-testcmake --build .build-choose-test --target arrow-compute-aggregate-test -j8.build-choose-test/release/arrow-compute-aggregate-test