Skip to content

test: improve OCI unit testing#4876

Merged
AustinAbro321 merged 6 commits into
mainfrom
improve-oci-testing
May 6, 2026
Merged

test: improve OCI unit testing#4876
AustinAbro321 merged 6 commits into
mainfrom
improve-oci-testing

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

Description

This is work that I've broken out of #4843. This introduces a test fixture for unit testing OCI objects so our tests don't need to rely on the upstream registry

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c69053b
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69fb342e48f5060008350d1d

@AustinAbro321 AustinAbro321 marked this pull request as ready for review May 5, 2026 16:28
@AustinAbro321 AustinAbro321 requested review from a team as code owners May 5, 2026 16:28
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor go backs but it also prompted a thought; I wonder if we need v1 documentation regarding exported APIs that are not included under the project umbrella of supported API's. We should be able to make breaking changes to API's under testing utilities?

Comment thread src/pkg/zoci/pull_test.go
Comment thread src/test/testutil/ociregistry.go Outdated
Comment thread src/pkg/zoci/pull_test.go
@github-project-automation github-project-automation Bot moved this to In progress in Zarf May 5, 2026
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
Copy link
Copy Markdown
Member Author

I would consider test APIs outside of the stable API promise

@AustinAbro321 AustinAbro321 requested a review from brandtkeller May 6, 2026 12:30
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit fa0352b May 6, 2026
43 checks passed
@AustinAbro321 AustinAbro321 deleted the improve-oci-testing branch May 6, 2026 20:36
@github-project-automation github-project-automation Bot moved this from In progress to Done in Zarf May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants