Skip to content

chore(deps): pin github.com/fsnotify/fsnotify to version 1.9.0#4881

Closed
soltysh wants to merge 3 commits into
zarf-dev:mainfrom
soltysh:pin_fsnotify
Closed

chore(deps): pin github.com/fsnotify/fsnotify to version 1.9.0#4881
soltysh wants to merge 3 commits into
zarf-dev:mainfrom
soltysh:pin_fsnotify

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented May 8, 2026

Description

Pin github.com/fsnotify/fsnotify to version 1.9.0, which based on conversations from kubernetes/kubernetes#138812 seems a safe option for now. The future versions are considered unwanted until we get an audit which was initiated by the kubernetes community.

Checklist before merging

@soltysh soltysh requested review from a team as code owners May 8, 2026 13:55
@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit c19c52b
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a0c79c9d4d6a60008a3cb92

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

soltysh added 2 commits May 19, 2026 16:28
…10.1

Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented May 19, 2026

Did some more reading and found we already rely on https://github.com/actions/dependency-review-action which has the ability to deny specific versions. Based on kubernetes/kubernetes#138812 I've denied 1.10.0 and 1.10.1.

For testing purposes, I've added 2nd commit for now, which actually bumps that library to one of the denied, to see what the CI will show. Once confirmed I'll drop this part.

@soltysh soltysh force-pushed the pin_fsnotify branch 3 times, most recently from 04830e1 to 394c60d Compare May 19, 2026 14:51
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented May 19, 2026

I did some more testing and I'm quite disappointed with https://github.com/actions/dependency-review-action, see:
image
I have explicitly denied a direct dependency (you can't deny indirect, and probably we shouldn't) and yet the job is perfectly green:
image

If we want to do that, we'll need to create our own script, probably somewhere in check-go-mode.yml file.

@soltysh soltysh closed this May 19, 2026
@github-project-automation github-project-automation Bot moved this to Done in Zarf May 19, 2026
@soltysh soltysh deleted the pin_fsnotify branch May 19, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant