Allow SafetyHardware to run without bumpers or e-stops#39
Open
pascalzauberzeug wants to merge 1 commit intomainfrom
Open
Allow SafetyHardware to run without bumpers or e-stops#39pascalzauberzeug wants to merge 1 commit intomainfrom
pascalzauberzeug wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The hardware safety module hard-required both
EStopHardwareandBumperHardwareinstances viaassert isinstance(...)in_generate_lizard_code().This blocked simpler robot variants that legitimately ship without bumpers and/or without e-stops (e.g. small devkit configurations) from using the same
SafetyHardwareclass.Implementation
_generate_lizard_code()drops the e-stop and bumperisinstanceassertions and emits the pin-watchingwhenblocks only when the matching hardware is present and exposes pins.estop_activeandbumper_activeare always declared, so the enable/disable transitions stay a single pair of rules regardless of which inputs exist.Progress