Skip to content

[maint]: append "${ZPFX}/lib/pkg-config" to $PKG_CONFIG_PATH plus others#547

Closed
psprint wants to merge 2 commits into
zdharma-continuum:mainfrom
psprint:build-systems-integration
Closed

[maint]: append "${ZPFX}/lib/pkg-config" to $PKG_CONFIG_PATH plus others#547
psprint wants to merge 2 commits into
zdharma-continuum:mainfrom
psprint:build-systems-integration

Conversation

@psprint

@psprint psprint commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

Description

I think that this PR is important so I'm refreshing it (old: #333). I think that to be able to easily compile things under $ZPFX is an important feature. When building with zinit's configure''/make'' ices the environment should point the build systems to $ZPFX directory as the location of headers and libraries.

Motivation and Context

I've once installed a library (pcre2-8) to $ZPFX and then tried to also install a dependent program (universal,-ctags) and I've noticed that the library wasn't found. After investigation it was pkg-config to blame, with a solution of prepending $ZPFX library dir to $PKG_CONFIG_PATH.

How Has This Been Tested?

A few builds of a few apps, like libpcre2, universal-ctags, weechat.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@psprint

psprint commented Jul 29, 2023

Copy link
Copy Markdown
Contributor Author

@vladdoster @pschmitt @alichtman ping

@psprint

psprint commented Aug 19, 2023

Copy link
Copy Markdown
Contributor Author

@vladdoster: ping. The build frameworks integration is needed and expected one, so it should be merged.

@alichtman

Copy link
Copy Markdown
Member

I don't understand the purpose of $ZPFX. A code search of the repo shows no explanation: https://github.com/search?q=repo%3Azdharma-continuum%2Fzinit%20ZPFX&type=code, and the name polaris is nondescript.

I think that to be able to easily compile things under $ZPFX is an important feature.

Why?

@psprint

psprint commented Aug 20, 2023

Copy link
Copy Markdown
Contributor Author

The purpose of $ZPFX is to have a prefix-dir similar to ~/.local, where users of zinit install their software. One can, of course, set it to: $HOME/.local.

I think that to be able to easily compile things under $ZPFX is an important feature.

Why?

Why? Because it's obvious…

@alichtman

Copy link
Copy Markdown
Member

I think it'd be really helpful if this stuff was documented somewhere in the README or website, instead of assuming that people will expand $ZPFX to "Zinit Prefix".

I wouldn't have made that jump on my own, especially given that the default directory name is polaris.

@psprint

psprint commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

Very true, $ZPFX isn't documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants