feat: check for completion files#618
Conversation
483d0c3 to
8e65a67
Compare
0c75196 to
ee9adb7
Compare
|
Automatically detect completion files 
|
|
@jankatins, thoughts? |
| typeset -aU completions already_symlinked backup_comps | ||
| local c cfile bkpfile | ||
| # The plugin == . is a semi-hack/trick to handle 'creinstall .' properly | ||
| nt () { |
There was a problem hiding this comment.
nt is just a random function name. It could be anything.
There was a problem hiding this comment.
Ok, stupid question: why not a speaking function name so one can actually know what it does by just reading the function name? reading the zinit code is hard enough even without random function names :-)
There was a problem hiding this comment.
|
To be honest, I'm fine with the "less magic" variant of renaming to What happens if two files end up getting symlinked under the same name? |
| assert __init__.py is_not_value_in $COMPS | ||
| zinit delete --yes test/ignored_completions | ||
| run zinit cuninstall test/ignored_completions | ||
| assert $output contains 'No completions found for `test/ignored_completions' |
There was a problem hiding this comment.
There should be a test with two files of the same name getting linked under different names.
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
e266994 to
627ea8e
Compare
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
3 participants
Description
Related Issue(s)
Motivation and Context
Usage examples
before
after
How Has This Been Tested?
Types of changes
Checklist: