Fix missing live ACP tool calls for collab agent events#192
Open
shadowpigy wants to merge 3 commits into
Open
Conversation
shadowpigy
force-pushed
the
codex/live-collab-toolcalls
branch
from
37cc70f to
d726109
Compare
Member
|
thanks for taking a look at this! Sorry about the merge conflicts, if you don't mind resolving those I can take another look |
…lcalls # Conflicts: # src/thread.rs
Author
|
Resolved the merge conflicts and pushed follow-up fixes in 25a81f8. I also added coverage for collab replay/payload schema and the wait timeout case. Would appreciate another look when you have a chance. |
|
I'm really looking forward to this feature going live. |
|
@benbrandt please merge it, thinks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the gap where collab agent tool calls appeared after
session/loadhistory replay but were missing from the initial live chat stream.The live ACP bridge now emits tool call notifications for:
spawn_agentsend_inputresume_agentwaitclose_agentThis change keeps
RawResponseItemandRealtimeConversation*handling unchanged so the patch stays focused on the collab/subagent tool-call path.Testing
cargo test collab_cargo build --release