Skip to content

Video embeds #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HookedBehemoth wants to merge 1 commit into from
Closed

Video embeds #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/routes/status.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ proc createStatusRouter*(cfg: Config) =
video = ""

if conv.tweet.video.isSome():
images = @[get(conv.tweet.video).thumb]
video = getVideoEmbed(cfg, conv.tweet.id)
let vid = get(conv.tweet.video)
images = @[vid.thumb]
let vids = vid.variants.filterIt(it.contentType == VideoType.mp4)
video = getVidUrl(vids[0].url)
elif conv.tweet.gif.isSome():
images = @[get(conv.tweet.gif).thumb]
video = getPicUrl(get(conv.tweet.gif).url)
Expand Down
6 changes: 5 additions & 1 deletion src/views/general.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,17 @@ proc renderHead*(prefs: Prefs; cfg: Config; req: Request; titleText=""; desc="";

if rss.len > 0:
meta(property="twitter:card", content="summary")
elif video.len > 0:
meta(property="twitter:card", content="player")
else:
meta(property="twitter:card", content="summary_large_image")

if video.len > 0:
meta(property="og:video:url", content=video)
meta(property="og:video:secure_url", content=video)
meta(property="og:video:type", content="text/html")
meta(property="og:video:type", content="video/mp4")
meta(name="twitter:player:stream", content=video)
meta(name="twitter:player:stream:content_type", content="video/mp4")

# this is last so images are also preloaded
# if this is done earlier, Chrome only preloads one image for some reason
Expand Down