Disable warnings for C2Y extensions by default#146
Merged
Conversation
awelzel
approved these changes
Apr 1, 2026
Contributor
awelzel
left a comment
awelzel
left a comment
There was a problem hiding this comment.
Is it only broker that produces these warnings? I was wondering if we could push the flag down to only affect auxil/broker (or even caf), but not sure.
Also wondering a bit if anything in CI will be upset - we'll see it with the bump?
Member
Author
Only broker right now, but they're all things we don't care about so I don't any reason to limit it to just broker. It also only shows up in clang-22 builds so it won't show up in bumps. It fixes it for those builds locally. I can bring it into zeek/zeek#5309, which is currently failing because of the warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with Clang 22/23 results in a big block warnings from Broker as reported in zeek/broker#499. We're unlikely to support C2Y (C26) any time soon, since we don't even support C23 yet. Disable the warnings for these extensions.