Skip to content

Only pass -Wno-c2y-extensions on Clang 19+#148

Merged
timwoj merged 1 commit into
masterfrom
topic/timw/only-disable-c2y-warnings-on-clang
Apr 28, 2026
Merged

Only pass -Wno-c2y-extensions on Clang 19+#148
timwoj merged 1 commit into
masterfrom
topic/timw/only-disable-c2y-warnings-on-clang

Conversation

@timwoj
Copy link
Copy Markdown
Member

@timwoj timwoj commented Apr 23, 2026

This option doesn't exist on GCC and so adding it results in additional warnings that it doesn't exist. Disable adding it unless we're using Clang >= 19, since that's the version that added the flag.

@timwoj timwoj force-pushed the topic/timw/only-disable-c2y-warnings-on-clang branch from 1ac4fd5 to 1c8cb48 Compare April 23, 2026 21:44
Copy link
Copy Markdown
Contributor

@awelzel awelzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timwoj timwoj merged commit eb55055 into master Apr 28, 2026
1 check passed
@timwoj timwoj deleted the topic/timw/only-disable-c2y-warnings-on-clang branch April 28, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants