Skip to content

Comments

feat(VEG-3468): Introduce the publish connector command#316

Merged
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/veg-3468-validation-for-connector-part-2
Feb 23, 2026
Merged

feat(VEG-3468): Introduce the publish connector command#316
saikambaiyyagari merged 1 commit intomasterfrom
skambaiyyagari/veg-3468-validation-for-connector-part-2

Conversation

@saikambaiyyagari
Copy link
Contributor

@saikambaiyyagari saikambaiyyagari commented Feb 20, 2026

Description

Adds an initial “publish connector” flow to the connectors CLI, including packaging built artifacts and uploading them via a presigned URL, plus a core helper for making non-authenticated/raw HTTP requests.

bdf3963 Add the publish connector command flow

Detail

JIRA: https://zendesk.atlassian.net/browse/VEG-3468

Checklist

  • 💂‍♂️ includes new unit and functional tests

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch 2 times, most recently from 7d9bea8 to 9980f8c Compare February 20, 2026 06:41
@saikambaiyyagari saikambaiyyagari marked this pull request as ready for review February 20, 2026 06:44
@saikambaiyyagari saikambaiyyagari requested review from a team as code owners February 20, 2026 06:44
Copilot AI review requested due to automatic review settings February 20, 2026 06:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an initial “publish connector” flow to the connectors CLI, including packaging built artifacts and uploading them via a presigned URL, plus a core helper for making non-authenticated/raw HTTP requests.

Changes:

  • Added requestRaw to zcli-core for making axios fetch-adapter requests without applying zcli auth configuration.
  • Introduced a new connectors publish command plus publish library helpers to create an archive, create a connector via API, and upload the package.
  • Added unit + functional tests and a zip fixture for the publish flow.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
packages/zcli-core/src/lib/request.ts Adds requestRaw helper for raw axios requests
packages/zcli-core/src/lib/request.test.ts Adds tests for requestRaw
packages/zcli-connectors/src/commands/connectors/publish.ts New CLI command implementing publish + validation-only flows
packages/zcli-connectors/src/lib/publish/publish.ts New publish helper functions (zip, create, upload)
packages/zcli-connectors/src/lib/publish/publish.test.ts Unit tests for publish helpers
packages/zcli-connectors/tests/functional/publish.test.ts Functional tests for the publish command
packages/zcli-connectors/fixtures/test-connector.zip Adds a zip fixture for tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch from 9980f8c to 6c9a0f1 Compare February 20, 2026 12:20
Copilot AI review requested due to automatic review settings February 20, 2026 12:22
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch from 6c9a0f1 to e2af4fb Compare February 20, 2026 12:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saikambaiyyagari saikambaiyyagari changed the title Add the publish connector command flow feat(VEG-3468): Introduce the publish connector command Feb 20, 2026
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch from e2af4fb to 8081933 Compare February 22, 2026 23:34
Copilot AI review requested due to automatic review settings February 23, 2026 01:38
@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch from 8081933 to 3f38207 Compare February 23, 2026 01:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

let packagePath: string | undefined

try {
packagePath = await createPackageArchive(path, connectorName)
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If createPackageArchive fails after the file is created (line 14) but before the 'close' event fires (line 19-20), the promise will reject without returning the packagePath. This means the partial zip file will remain on disk and won't be cleaned up by the finally block at line 117-119, since packagePath will be undefined. Consider storing the packagePath in a way that allows cleanup even if archive creation fails, or handle errors in createPackageArchive to clean up partial files before rejecting.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@mmassaki mmassaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. I just left a nit one.

@saikambaiyyagari saikambaiyyagari force-pushed the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch from 3f38207 to bdf3963 Compare February 23, 2026 01:53
@saikambaiyyagari saikambaiyyagari merged commit 8f4c973 into master Feb 23, 2026
7 checks passed
@saikambaiyyagari saikambaiyyagari deleted the skambaiyyagari/veg-3468-validation-for-connector-part-2 branch February 23, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants