[POC] Add Expectation::isJson() to verify json string and decode#19
Draft
kbond wants to merge 1 commit intozenstruck:1.xfrom
Draft
[POC] Add Expectation::isJson() to verify json string and decode#19kbond wants to merge 1 commit intozenstruck:1.xfrom
Expectation::isJson() to verify json string and decode#19kbond wants to merge 1 commit intozenstruck:1.xfrom
Conversation
Member
Author
|
Not sure we want to do this but wanted to capture our conversation with a POC. We could go even further and move the |
nikophil
reviewed
Jul 12, 2022
| * | ||
| * Fails if not a valid json string. | ||
| */ | ||
| public function isJson(): self |
Member
There was a problem hiding this comment.
not sure of the name: it sounds like it's just an expectation, but it does more... decodeJson() ?
Member
Author
There was a problem hiding this comment.
Yeah, this tripped me up as well. Technically it is also an expectation but is not clear that it changes the underlying data.
I chose this purely because the api reads better: "assert that value is json" vs "assert that value decode json". I definitely probably get too hung up on these semantics 😄.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per a slack discussion with @nikophil.