Draft
Conversation
432a48e to
3cba1cd
Compare
nikophil
approved these changes
Apr 13, 2023
Member
nikophil
left a comment
There was a problem hiding this comment.
👌 LGTM
for my information, what was the complexity of using these html expectations in zenstruck/browser. It feels like thos packages could be compatible
|
|
||
| jobs: | ||
| tests: | ||
| uses: zenstruck/.github/.github/workflows/php-test.yml@main |
Member
There was a problem hiding this comment.
why have you decided to stop using the shared actions?
Member
Author
There was a problem hiding this comment.
env variables aren't passed down to shared actions.
Member
There was a problem hiding this comment.
if you need this behavior more than once, I'm pretty sure there is some hackto do to pass envs from workflow to external action
Member
Author
|
I actually have an alternative system I'm cooking up. Stay tuned :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a new zenstruck/assert-html package which is like a plugin for this library to make html assertions.
I've extracted this code from zenstruck/browser and will create a followup PR there to utilize this new library.edit: doing this created more complexity than I liked. Additionally, this new package will allow zenstruck/mailer-test#1.Some notes:
TODO: