Conversation
Contributor
Author
|
Theorically fixed for sca job. But the other are related to something I don't really understand and was not able to test locally, maybe due to my php version. @nikophil maybe some feedback/help about that? Thanks |
Member
|
the CI is failing https://github.com/zenstruck/browser/actions/runs/17002861742, sadly I don't know why and I don't have time these days for this - I may have some time to work on this in few weeks it seems that there are two different problems:
I really don't know where the first problem is coming from... The second problem sounds like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
As a warmup for another PR ^^