Skip to content

Dev 8037 allow docker pre build tasks and python version matrix#109

Merged
chestm007 merged 11 commits intomainfrom
DEV-8037-allow-docker-pre-build-tasks-and-python-version-matrix
May 7, 2026
Merged

Dev 8037 allow docker pre build tasks and python version matrix#109
chestm007 merged 11 commits intomainfrom
DEV-8037-allow-docker-pre-build-tasks-and-python-version-matrix

Conversation

@chestm007
Copy link
Copy Markdown
Contributor

Description

allow docker compose pre-build tasks
configurable python version matrix for builds
configurable python version for releases

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

Possible breaking change to ANY python repo:

  • if it uses tox, but doesnt specify py{310, 311, ...} etc as an environment matrix, the workflow will blow up, easy fix, let me know if this hits you before I get too it.

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@chestm007 chestm007 requested a review from alourie April 24, 2026 02:33
@ryanjcoleman
Copy link
Copy Markdown
Member

@alourie alourie marked this pull request as draft April 24, 2026 02:39
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@chestm007 chestm007 marked this pull request as ready for review April 24, 2026 03:54
Copy link
Copy Markdown
Contributor

@alourie alourie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just make sure other repos work using this - important not to break other things.

@chestm007 chestm007 merged commit 6ded6b2 into main May 7, 2026
1 check passed
@chestm007 chestm007 deleted the DEV-8037-allow-docker-pre-build-tasks-and-python-version-matrix branch May 7, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants