Skip to content

[DEV-6863] Support negligible impedance thresholds#63

Merged
vincewhite merged 1 commit intomainfrom
DEV-6863-Support_negligible_impedance_thresholds
May 4, 2026
Merged

[DEV-6863] Support negligible impedance thresholds#63
vincewhite merged 1 commit intomainfrom
DEV-6863-Support_negligible_impedance_thresholds

Conversation

@vincewhite
Copy link
Copy Markdown
Member

Description

Add support for passing negligibleImpedanceMinHvThreshold and negligibleImpedanceMinLvThreshold into model config

Associated tasks

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Request object change/new work package config fields/commons

Signed-off-by: vince <vince.white@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

Task linked: DEV-6863 Update eas-client-python

@vincewhite vincewhite merged commit 4028199 into main May 4, 2026
5 checks passed
@vincewhite vincewhite deleted the DEV-6863-Support_negligible_impedance_thresholds branch May 4, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants