We❤generators

[chestm007]

Description

Modifies some of the usages of generators to just yield from the genexp rather then a list comp, changes ngen to a 1 liner, no behavioural changes included

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

• [ X ] I have performed a self review of my own code (including checking issues raised when creating the PR).
• [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
• [ X ] I have commented my code in any hard-to-understand or hacky areas.
• [ X ] I have handled all new warnings generated by the compiler or IDE.
• [ X ] I have rebased onto the target branch (usually main).

Documentation

• [ ] I have updated the changelog.
• [ ] I have updated any documentation required for these changes.

Breaking Changes

• [ ] I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

[alourie]

yea we do ❤ generators