Skip to content

[DEV-6155] Neutral only network#221

Merged
charlta merged 1 commit intomainfrom
DEV-6155-neutral-only-networks
Apr 7, 2026
Merged

[DEV-6155] Neutral only network#221
charlta merged 1 commit intomainfrom
DEV-6155-neutral-only-networks

Conversation

@charlta
Copy link
Copy Markdown
Member

@charlta charlta commented Apr 7, 2026

Description

Added path tracking and conditions to allow correct tracing of networks with neutral-only sections, particularly with ShuntCompensators with a groundingTerminal connected to those sections. To facilitate this, there are breaking changes to the ShuntCompensator.groundingTerminal (see below).

Test Steps

N/A.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Not likely to break anything as I don't think these are being used anywhere really:

  • The ShuntCompensator.groundingTerminal must now:
    • Belong to the ShuntCompensator. Assigning a Terminal to ShuntCompensator.groundingTerminal will now set the terminals conductingEquipment to the
      ShuntCompensator if it isn't set, and throw an IllegalArgumentException if it is assigned to a different ConductingEquipment.
    • Be in the ShuntCompensator.terminals collection, and will be added automatically if it is missing on assignment, which in turn will update the
      sequenceNumber of the Terminal if it is 0.
    • Have phases N.
  • Phase paths through a ShuntCompensator now add paths for mismatched phases between the grounding and normal terminals. This works in the same way as the
    PowerTransformer. This will only impact traces that are tracking the included phase paths, and will allow traces that previously stopped at the
    ShuntCompensator to continue. You should use the new stopOnShuntCompensatorGround condition to maintain current behaviour.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

Task linked: DEV-6155 Update Python SDK

@charlta charlta marked this pull request as ready for review April 7, 2026 06:01
@charlta charlta requested a review from chestm007 April 7, 2026 06:01
@charlta charlta merged commit 6fc09d3 into main Apr 7, 2026
5 checks passed
@charlta charlta deleted the DEV-6155-neutral-only-networks branch April 7, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants