Merged
Conversation
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Member
|
Task linked: DEV-6155 Update Python SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added path tracking and conditions to allow correct tracing of networks with neutral-only sections, particularly with
ShuntCompensators with agroundingTerminalconnected to those sections. To facilitate this, there are breaking changes to theShuntCompensator.groundingTerminal(see below).Test Steps
N/A.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
- [ ] I have updated any documentation required for these changes.Breaking Changes
Not likely to break anything as I don't think these are being used anywhere really:
ShuntCompensator.groundingTerminalmust now:ShuntCompensator. Assigning aTerminaltoShuntCompensator.groundingTerminalwill now set the terminalsconductingEquipmentto theShuntCompensatorif it isn't set, and throw anIllegalArgumentExceptionif it is assigned to a differentConductingEquipment.ShuntCompensator.terminalscollection, and will be added automatically if it is missing on assignment, which in turn will update thesequenceNumberof theTerminalif it is0.N.ShuntCompensatornow add paths for mismatched phases between the grounding and normal terminals. This works in the same way as thePowerTransformer. This will only impact traces that are tracking the included phase paths, and will allow traces that previously stopped at theShuntCompensatorto continue. You should use the newstopOnShuntCompensatorGroundcondition to maintain current behaviour.