Fix timer / condvar requirements#145
Open
nashif wants to merge 2 commits into
Open
Conversation
nashif
commented
Jun 25, 2026
nashif
commented
Member
- requirements: correct Timers requirement types and wording
- requirements: fix Condition Variables parent links and sync wording
Audit of the Timers requirements against the k_timer API found minor
classification and wording issues:
- ZEP-SRS-4-7 (timer status) and ZEP-SRS-4-8 (status reinitialization)
were typed Non-Functional, but reading and resetting a timer's
expiration count is functional behavior; change them to Functional.
- Reword ZEP-SRS-4-8 and ZEP-SRS-4-9 for clarity ("the timer number of
times it has expired", "superior to 0" -> "the timer's expiration
count", "greater than zero").
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Spot-check of the synchronization primitive documents found:
- All Condition Variables requirements (ZEP-SRS-21-*) linked to
ZEP-SYRS-20 (the Interrupts "Direct ISR" system requirement) instead
of ZEP-SYRS-21 (Condition Variables). Correct the parent links.
- Fix typos in the Condition Variables document ("priorite" -> "priority";
a statement beginning "henever" -> "Whenever") and reword the
mutex-release-on-wait requirement to state the atomic release and
re-acquire behavior accurately.
- Semaphore: two requirements shared the title "Semaphore release";
rename one to "Semaphore count increment on release". Retitle
"Semaphore release with priority inheritance" to "Highest-priority
waiter unblocked on release", since semaphores do not implement
priority inheritance (the statement was already correct).
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.