feat(react-ui): SelectDropdown component#321
Open
OmarBasem wants to merge 6 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OmarBasem
changed the title
OmarBasem
marked this pull request as draft
July 10, 2026 08:17
OmarBasem
changed the title
OmarBasem
changed the title
OmarBasem
marked this pull request as ready for review
July 10, 2026 09:38
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 14, 2026 12:27
179f991 to
cf04c8c
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 14, 2026 12:27
809972b to
72405d7
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 14, 2026 12:37
72405d7 to
dd32b76
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 14, 2026 12:37
cf04c8c to
d10bcf1
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 14, 2026 13:11
d10bcf1 to
e7f7f94
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 14, 2026 13:19
030f2e7 to
c55bfa9
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 14, 2026 13:19
e7f7f94 to
252b392
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 15, 2026 05:36
252b392 to
ec6950c
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 15, 2026 05:45
ec6950c to
1c0851b
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 15, 2026 05:45
997be70 to
1acb066
Compare
andrascodes
reviewed
Jul 15, 2026
| @@ -0,0 +1,216 @@ | |||
| import { | |||
Collaborator
There was a problem hiding this comment.
The Default story looks a bit off. It might be just an issue with the story file layout itself
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 15, 2026 13:29
1c0851b to
45a13b3
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 15, 2026 13:29
1acb066 to
8473f8f
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
2 times, most recently
from
July 16, 2026 06:48
9d5d550 to
ff3ef31
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 16, 2026 06:49
9ecdc9b to
68fd347
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 16, 2026 06:49
ff3ef31 to
6858226
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 16, 2026 13:48
68fd347 to
bce9516
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 16, 2026 13:48
6858226 to
48c50b6
Compare
OmarBasem
force-pushed
the
omar/token-list-item
branch
from
July 16, 2026 14:04
bce9516 to
c06d635
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 16, 2026 14:04
48c50b6 to
8f7972b
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 16, 2026 14:10
8f7972b to
ff9b411
Compare
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 16, 2026 14:19
ff9b411 to
cfc4ad5
Compare
commit: |
# Conflicts: # packages/react-ui/src/components/DataRow/index.tsx # packages/smart-routing-address-react-ui/src/components/LabeledValueRow/LabeledValueRow.stories.tsx # Conflicts: # packages/smart-routing-address-react-ui/src/pages/Deposit.tsx # Conflicts: # packages/react-ui/src/components/PillItem/PillItem.test.tsx # packages/react-ui/src/components/PillItem/index.tsx
OmarBasem
force-pushed
the
omar/token-dropdown
branch
from
July 17, 2026 07:37
73bd63d to
4758aea
Compare
Member
Author
|
@andrascodes @brtkx thanks for your reviews, I have refactored to using Radix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FS-2398