feat(wallet-react-ui): PoC add external-wallet auth method#323
Draft
brtkx wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
andrascodes
reviewed
Jul 16, 2026
andrascodes
left a comment
Collaborator
There was a problem hiding this comment.
I like this approach a lot. Or at least I definitely can't think of a better one.
It stays more or less out of the way of our Embedded Wallet flows. It gives us the same capability that for example Privy has and it looks great. The mobile connection is also a great plus. So nice job! I think you devised a great solution!
brtkx
force-pushed
the
bartek/poc/third-party-wallets
branch
from
July 20, 2026 14:38
8e08cb8 to
8bb15a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
external-walletsign-in method to the kit: injected wallets via EIP-6963 auto-discovery plus an in-house WalletConnect QR step — own UI end to end, no Reown components, no runtime registry API. PoC scope.Done & working
'external-wallet'inAuthMethod; SignUp gains "Continue with a wallet" →wallet-selectionstep.connect, the wallet's own provider serves RPC afterwards (embedded wallet andprovider.tsnever involved).walletGuide.ts: 10 wallets (name,rdns, inline SVG icon, mobile deep-link prefix, download URL). Rows currently open the vendor download page.walletConnect({ showQrModal: false })from newZeroDevKitConfig.walletConnectProjectId(registered via the same_internalpath wagmi's ownconnect()uses; reuses a dev-added WC connector if present); subscribesdisplay_uribefore connecting; QR rendered in-house withuqr.walletConnectProjectIdflows kit config → kit store (same pattern aslogo).uqr@^0.1.3(kit).Still to do (not in this PR)
How to test
pnpm --filter @zerodev/signer-demo dev→localhost:3000.