feat(core): rename stampers and expose them on createZeroDevWallet#71
Merged
Conversation
This was referenced Apr 1, 2026
andrascodes
force-pushed
the
core_expose_stampers
branch
from
April 1, 2026 17:11
54fa0c4 to
1800c58
Compare
This was referenced Apr 1, 2026
andrascodes
force-pushed
the
core_expose_stampers
branch
from
April 7, 2026 11:21
1800c58 to
7c1df70
Compare
andrascodes
marked this pull request as ready for review
April 7, 2026 16:54
OmarBasem
reviewed
Apr 8, 2026
andrascodes
force-pushed
the
core_expose_stampers
branch
from
April 20, 2026 10:11
892cc8f to
3819862
Compare
andrascodes
force-pushed
the
core_expose_stampers
branch
from
April 24, 2026 17:57
3819862 to
f3b5f87
Compare
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. The architectural direction is right — moving stampers to injected dependencies and the prepare/commit key rotation API is a clear improvement. Comments are mostly about consistency follow-through:
- The
StamperTyperename is half-finished; doing it atomically here avoids the// TODO: @stamper-typemarkers landing in main. publicKeyfield tightening surfaced a pre-existing weakness in the OAuth path (non-blocking).- Misc nits on docstrings.
Approve conceptually, just want the rename consistency before merge.
This was referenced Apr 28, 2026
andrascodes
force-pushed
the
core_expose_stampers
branch
2 times, most recently
from
May 5, 2026 11:28
49ad4b7 to
2ba28ae
Compare
andrascodes
changed the base branch from
main
to
andras/feat-core-use-noble-ciphers-aes-for-mobile-compat
May 5, 2026 13:22
andrascodes
force-pushed
the
core_expose_stampers
branch
from
May 5, 2026 13:22
2ba28ae to
ffc0e8a
Compare
andrascodes
changed the base branch from
andras/feat-core-use-noble-ciphers-aes-for-mobile-compat
to
main
May 5, 2026 14:30
andrascodes
force-pushed
the
core_expose_stampers
branch
from
May 5, 2026 14:31
ffc0e8a to
02e10cd
Compare
SahilVasava
approved these changes
May 5, 2026
SahilVasava
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — all prior review comments addressed (StamperType renamed to 'apiKey' | 'passkey', OAuth path now fails loud on missing public key, parseSession deduped to single token field, docstrings clarified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
mainCloses FS-1925, FS-1946
Renamed the stampers to a more generic name
apiKeyStamperandpasskeyStampers. Exposed them so they can be passed in throughcreateZeroDevWallet(). But I haven't removed the defaultindexedDbStamperandwebauthnStamperso this is not a breaking change.(will add more documentation later)