Skip to content

docs(skill): add "keep related scenarios in one tree" guidance #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepan-romankov merged 1 commit into from
May 21, 2026
Merged

docs(skill): add "keep related scenarios in one tree" guidance #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/claude-setup/skill/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ For samurai test files, top-to-bottom:

Rationale: tests on top so the file's contract is visible immediately; setup stays local when it has a single caller, and graduates to a helper when it doesn't; helpers are appendix.

### Keep related scenarios in one tree

Decision test: does one scenario's mutation produce the state another scenario reads back? If yes, they belong in the same file and the same `RunWith` tree — the shared mutation is the parent, the divergent read-backs are the leaves (grant → "read shows present" vs. revoke → "read shows absent"). This is the branching state-mutating tree samurai exists for.

Splitting such scenarios one-file-per-action duplicates the setup and the context type and hides the grant/revoke/read-back relationship behind file boundaries. Independent features — where no scenario observes another's mutation — still get their own files.

## When to Use

USE samurai when ALL of these hold:
Expand Down