Drop gRPC reference from naming.md HTTP heuristic#25
Merged
Conversation
The "Why it's bad" cell for HTTP status codes used gRPC as a hypothetical contrast ("the same behaviour at gRPC would be unnamable"). The rule is about not coupling the test name to the transport layer at all — calling out gRPC narrows the framing unnecessarily. Reworded to make the transport-independence the point: the domain outcome reads the same regardless of how the response is shaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The HTTP-status-leak heuristic in
cmd/claude-setup/skill/naming.mdused gRPC as a hypothetical contrast ("the same behaviour at gRPC would be unnamable"). The rule is about not coupling test names to the HTTP transport at all — calling out gRPC narrows the framing unnecessarily.Reworded to make transport-independence the point: "the domain outcome reads the same regardless of how the response is shaped".
Test plan
gRPC/grpcreferences in the skill — only the one heuristic cell used it.🤖 Generated with Claude Code