Skip to content

fix(ci) - fix release ci#302

Open
zevwings wants to merge 1 commit intomasterfrom
bugfix/fix-release-ci
Open

fix(ci) - fix release ci#302
zevwings wants to merge 1 commit intomasterfrom
bugfix/fix-release-ci

Conversation

@zevwings
Copy link
Owner

PR Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which does not change functionality)
  • Hotfix (urgent fix for production issues)
  • Chore (maintenance tasks and non-functional changes)

Summary

修复发布 CI 工作流,使其依据 correct_version 步骤的输出决定是否执行版本相关步骤。

Key Changes

  • 为四个关键步骤新增 if: 条件,检查 steps.correct_version.outputs.needs_increment
  • 将原有仅依赖 generate_version 的条件扩展为同时支持 correct_version
  • 更新工作流文档注释以说明新条件的作用

Changes

Bug Fixes

  • 修正发布流程条件判断错误,防止因条件缺失导致的发布失败

Configuration

  • 修改 .github/workflows/release.yml 中的条件表达式

Impact Analysis

Affected Modules

Module Impact Severity
release.yml 工作流 CI 条件更改,可能导致部分步骤被跳过或执行顺序变化 medium

Risk Assessment

Overall risk: medium

Risk factors:

  • YAML 中出现重复的 if: 键可能导致解析错误
  • 依赖 correct_version 步骤的输出,如果该步骤不存在或输出异常,发布流程将被中断

Mitigation:

  • 确保每个步骤仅保留一个 if:,必要时合并原有条件与新条件
  • 在工作流中添加注释并验证 correct_version 步骤在前置位置运行
  • 在 CI 环境中执行完整的发布流程测试,确认条件生效

Testing Suggestions

  • 在 CI 环境触发 release 工作流,验证版本文件更新、制品上传等步骤是否按预期执行
  • 模拟 correct_version 输出为 true/false,检查对应步骤的启停情况

Statistics

Metric Value
Total files 1
Additions +4
Deletions -4
Net change 0
Added files 0
Modified files 1
Deleted files 0
Renamed files 0

Review Info

  • Complexity: simple
  • Review priority: medium
  • Estimated review time: 15 minutes
  • Tags: ci, fix, release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant