-
Notifications
You must be signed in to change notification settings - Fork 11
Modernize foundation 6.9 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpasternak
wants to merge
7
commits into
zflat:master
Choose a base branch
from
mpasternak:modernize-foundation-6.9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c1f89bc
modernize gemspec: target foundation-rails 6.9, drop stale deps, bump…
mpasternak 0e0970a
modernize npm/bower build: foundation-sites 6.9, dart-sass, peerDepen…
mpasternak 356d054
add GitHub Actions CI for gem install and npm build
mpasternak ad288c8
docs/gitignore: CI + license badges, npm install docs, changelog 0.2.0
mpasternak bf5acaf
address PR review: rake test against styleguide06, drop legacy sample…
mpasternak 7b7b0ec
ci: run on push to any branch + add workflow_dispatch + concurrency
mpasternak eef5703
ci: drop --local from gem install so runtime deps resolve from rubygems
mpasternak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| branches: [master, main] | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| gem: | ||
| name: gem (ruby ${{ matrix.ruby }}) | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: ["3.0", "3.1", "3.2", "3.3"] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| bundler-cache: true | ||
|
|
||
| - name: Build gem | ||
| run: gem build select2-foundation.gemspec | ||
|
|
||
| - name: Install built gem (with runtime deps) | ||
| run: | | ||
| gem install select2-foundation-*.gem | ||
| gem list select2-foundation | ||
|
|
||
| - name: Run gem test suite against test/styleguide06 | ||
| run: bundle exec rake test | ||
|
|
||
| npm: | ||
| name: npm (node ${{ matrix.node }}) | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node: ["18", "20", "22"] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node }} | ||
|
|
||
| - name: Install npm dependencies | ||
| run: npm install --no-audit --no-fund | ||
|
|
||
| - name: Build SCSS | ||
| run: npm run build | ||
|
|
||
| - name: Verify dist output | ||
| run: | | ||
| test -s dist/select2-foundation-theme.css || { echo "dev CSS not produced"; exit 1; } | ||
| test -s dist/select2-foundation-theme.min.css || { echo "prod CSS not produced"; exit 1; } | ||
| echo "dev: $(wc -c < dist/select2-foundation-theme.css) bytes" | ||
| echo "prod: $(wc -c < dist/select2-foundation-theme.min.css) bytes" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update, thanks!