Skip to content

Add for Discord#33

Draft
AdityaMH wants to merge 1 commit intozhanghai:masterfrom
AdityaMH:how-to-get-id-lol
Draft

Add for Discord#33
AdityaMH wants to merge 1 commit intozhanghai:masterfrom
AdityaMH:how-to-get-id-lol

Conversation

@AdityaMH
Copy link
Copy Markdown

Add PR for discord media sharing utility
Just curious, how to get id for each rules?

Just get id, and PR ready to merge

  • Tests pass
  • Appropriate changes to README are included in PR

Add PR for discord media sharing utility
Just curious, how to get id for rules? lol
@AdityaMH AdityaMH marked this pull request as draft April 26, 2024 02:39
Copy link
Copy Markdown

@xbibibubux96-lang xbibibubux96-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7

Rule(
id = "",
name = "Discord CDN Replacement",
description = "Replace media link from MEDIA to CDN from Discord media.",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a good thing?

description = "Remove Discord attachment tracking",
script =
"""
if ($.matches(url, '(media|cdn)\\.discordapp\\.(com|net)')) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only match the intended domains

(cdn\\.discordapp\\.com|media\\.discordapp\\.net)

This comment was marked as off-topic.

Comment on lines +149 to +150
name = "Discord Attachment",
description = "Remove Discord attachment tracking",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discord and Remove tracking for Discord - we can do multiple things in the same rule, while I don't want to have too many rules unless they have a valid use case to be enabled/disabled separately.

enabled = false
),
Rule(
id = "",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run UUID.randomUUID().toString() to generate a new UUID.

@zhanghai
Copy link
Copy Markdown
Owner

zhanghai commented Oct 4, 2025

You need to sign the CLA to contribute to this project, see https://github.com/zhanghai/Untracker/blob/master/docs/contributing.md .

@zhanghai zhanghai force-pushed the master branch 4 times, most recently from 41dedb0 to 4b3fdc9 Compare February 19, 2026 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants