fix(ots): use time_t for openssl_time_cb signature#406
Merged
zhaozg merged 1 commit intozhaozg:masterfrom Feb 24, 2026
Merged
Conversation
Updated openssl_time_cb to use time_t* for the seconds parameter to match LibreSSL 4.2.1's TS_time_cb definition. This fixes incompatible function pointer errors on Windows x64 using IntelLLVM compiler.
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compilation error on Windows x64 using Intel LLVM compiler:
Related Issue
None.
Type of Change
Changes Made
Updated
openssl_time_cb()to usetime_t*for the seconds parameter to match LibreSSL 4.2.1'sTS_time_cbdefinition. This fixes incompatible function pointer errors on Windows x64 using IntelLLVM compiler. Seeopenssl/ts.h.Testing
Please describe the tests you ran to verify your changes:
Checklist
OpenSSL Compatibility
Please indicate which OpenSSL versions were tested (if applicable):
Additional Notes
None.