Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 317ec52d40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Project Path="TensorSharp.GGML/TensorSharp.GGML.csproj" /> | ||
| <Project Path="TensorSharp/TensorSharp.csproj" /> | ||
| </Solution> | ||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
There was a problem hiding this comment.
Use SLNX schema in .slnx files
Changing the root element to <Project> makes this a traversal MSBuild project, not an SLNX solution file. On toolchains that natively support .slnx (for example .NET SDK 9.0.200+ / VS 17.14+), .slnx is parsed with the SLNX serializer and expects a <Solution> root, so solution operations (such as dotnet sln ...) and builds targeting TensorSharp.slnx can fail as an invalid solution format. Since this repo documents dotnet build TensorSharp.slnx, keeping non-SLNX XML under a .slnx extension introduces a compatibility regression.
Useful? React with 👍 / 👎.
Motivation
MSB4068parsing error where<Solution>inTensorSharp.slnxis unrecognized by some .NET/MSBuild toolchains by making the file valid MSBuild XML.Description
<Solution>format inTensorSharp.slnxwith a standard MSBuild<Project>file that includes all projects in aProjectsToBuilditem group and addsBuild,Clean,Restore, andRebuildtargets that forward to each project while propagatingConfigurationandPlatform.Testing
dotnet build TensorSharp.slnx -c Releasecould not be executed in this environment becausedotnetwas not installed (error:/bin/bash: dotnet: command not found).TensorSharp.slnxcontents and verified it contains theItemGroupwith project entries and the expected MSBuild targets.Codex Task