Skip to content

Add webview font fallbacks#46

Open
subhajitlucky wants to merge 1 commit into
zigcBenx:masterfrom
subhajitlucky:fix-font-fallbacks-33
Open

Add webview font fallbacks#46
subhajitlucky wants to merge 1 commit into
zigcBenx:masterfrom
subhajitlucky:fix-font-fallbacks-33

Conversation

@subhajitlucky
Copy link
Copy Markdown

Fixes #33.

Summary

  • Adds explicit sans-serif fallbacks for UI text that uses the VS Code UI font variable.
  • Adds editor/UI/monospace fallback chains for search result and preview code text.
  • Prevents the webview from falling back to browser serif defaults when a configured VS Code font is unavailable.

Validation

  • npm run compile
  • git diff --check

Note: npm run lint still fails because the repository has no ESLint configuration file for the existing lint script.

Copilot AI review requested due to automatic review settings May 13, 2026 03:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #33 by ensuring the webview’s typography consistently falls back to sensible default font families when VS Code-provided font variables resolve to unavailable fonts on a given machine.

Changes:

  • Add explicit sans-serif fallbacks for UI text using --vscode-font-family.
  • Add editor/UI/monospace fallback chains for match text and preview code content using --vscode-editor-font-family.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect font

2 participants