stage2: fix @sizeOf() for vector types.#12028
Closed
xxxbxxx wants to merge 1 commit intoziglang:masterfrom
Closed
Conversation
Member
|
Thanks for the patch! Note that this changed in LLVM 14. Here is the corresponding alignment patch: b698168 |
xxxbxxx
force-pushed
the
master
branch
3 times, most recently
from
903a1a7 to
a39eab8
Compare
Contributor
Author
|
not smart enough to get the tests to pass both on llvm13 and llvm14 -> rebasing on llvm14 branch.. |
xxxbxxx
force-pushed
the
master
branch
4 times, most recently
from
3056641 to
b936762
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stage1 does
entry->abi_size = LLVMABISizeOfType(g->target_data_ref, example_vector_llvm_type); entry->abi_align = LLVMABIAlignmentOfType(g->target_data_ref, example_vector_llvm_type);but looks like it's actually pretty direct, same as alignment. (next power-of-2)
maybe some architectures are different?
follow-up of 095e24e
closes #12026