Skip to content

Add collapseRepeatsAll function.#25503

Open
AndrewKraevskii wants to merge 2 commits intoziglang:masterfrom
AndrewKraevskii:collapse
Open

Add collapseRepeatsAll function.#25503
AndrewKraevskii wants to merge 2 commits intoziglang:masterfrom
AndrewKraevskii:collapse

Conversation

@AndrewKraevskii
Copy link
Copy Markdown
Contributor

Every time I read collapseRepeats I think it should do what I need but every time I finding out it only deduplicates provided element.
Some bikeshading. This renaming would make sense

  • collapseRepeats -> collapseRepeatsScalar
  • collapseRepeatsAll -> collapseRepeats
  • collapseRepeatsLen -> remove it since its easy to write collapseRepeats().len instead

Makes it clear what only passed element will be deduplicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant