test: cover embedding provider factory edge cases#231
Open
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
Open
test: cover embedding provider factory edge cases#231haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DEFAULT_MODELSWhy
Follow-up coverage for #114.
The embeddings factory contains pure dispatch and dependency-error logic that can regress silently without unit tests. This patch locks down provider selection, optional kwargs handling, and the helpful install-hint error path.
Testing
uv run python -m pytest tests/test_embeddings_factory.py -quv run ruff check tests/test_embeddings_factory.pyuv run ruff format --check tests/test_embeddings_factory.py