Skip to content

test: cover nested env-ref dict resolution#281

Open
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
haosenwang1018:test/config-env-ref-dict-coverage
Open

test: cover nested env-ref dict resolution#281
haosenwang1018 wants to merge 1 commit intozilliztech:mainfrom
haosenwang1018:test/config-env-ref-dict-coverage

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • add focused coverage for _resolve_env_refs_in_dict() resolving nested env: string values
  • verify non-string values like bools and ints pass through unchanged
  • keep the patch scoped to config helper branches under issue test: improve test coverage across the project #114

Testing

  • uv run python -m pytest tests/test_config.py -q
  • uv run ruff check tests/test_config.py
  • uv run ruff format --check tests/test_config.py

Refs #114

@zc277584121
Copy link
Copy Markdown
Collaborator

This PR has merge conflicts after recent merges to main (multiple PRs added tests to the same region of test_config.py). Could you rebase on latest main to resolve? Thanks!

Copy link
Copy Markdown
Collaborator

@zc277584121 zc277584121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good and are ready to merge, but this PR now has merge conflicts with main (likely from other test PRs that landed on tests/test_config.py). Could you rebase on latest main? I'll merge once the conflicts are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants