feat: add --host argument to support remote port binding#48
Open
ChineseAStar wants to merge 1 commit intozinja-coder:mainfrom
Open
feat: add --host argument to support remote port binding#48ChineseAStar wants to merge 1 commit intozinja-coder:mainfrom
ChineseAStar wants to merge 1 commit intozinja-coder:mainfrom
Conversation
|
I have made more comprehensive modifications: #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when running the server in HTTP mode (
--http), it implicitly binds to127.0.0.1. This makes it impossible to access the MCP server remotely or run it effectively within Docker containers or remote VMs.This PR introduces a
--hostparameter to the command-line interface, allowing users to specify the IP address the server should bind to. Users can now easily bind to0.0.0.0or any specific network interface for remote access, while keeping the default behavior secure.Changes
--hostargument toargparsewith a default value of127.0.0.1to maintain the existing secure behavior.hostargument tomcp.run(transport="streamable-http", host=args.host, port=args.port)insidejadx_mcp_server.py.How to Test
Test default behavior (Localhost only):
Verify that the server only listens on
127.0.0.1.Test remote access binding:
Verify that the server successfully binds to
0.0.0.0and can be accessed via your local network IP.