Telnet server demo (for your Go telnet lib)#1
Open
mahan wants to merge 1 commit intoziutek:masterfrom
Open
Conversation
… telnet server demo.
Owner
|
Hmm... This package is designed for write telnet clients. Telnet protocol is symmetrical but real telnet server should actively negotiate some parameters for session. Your example code may suggest that this package can be used to write real servers, but really it work like client connected with other client. This can be misleading. |
044e4df to
1b219d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've written a server demo for your Golang telnet library.
I think it might provide a good additional starting point for your presumptive users if they want to understand quickly and get up and running fast.
Feel free to pull in my changes if you like them.
Best regards,
/MattiasH