Unread badges for tabs by pioneer · Pull Request #145 · zjs81/meshcore-open

pioneer · 2026-02-09T14:34:06Z

Bottom tabs (Contacts, Channels) didn't show whether there are new messages in channels or in direct messages. Now, when any channel has a new message, the Channels tab receives a red dot unread badge. Same for Contacts.

Copilot

Pull request overview

Adds unread-count badges to the bottom navigation tabs (Contacts/Channels) and introduces a new Contacts list ordering toggle to keep people (users) at the top, with localization updates to support the new UI label.

Changes:

Add unread badge rendering to QuickSwitchBar and wire unread totals from MeshCoreConnector into screens using the bottom navigation.
Add a “users/people first” toggle to the Contacts filter menu and update contacts sorting to partition users before other contact types.
Add the new localization key + Ukrainian translation, and update untranslated.json plus generated localization outputs.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
untranslated.json	Updates the untranslated-keys list to reflect the new `listFilter_usersFirst` string.
lib/widgets/quick_switch_bar.dart	Adds badge display to Contacts/Channels icons and adds selected icon for Map.
lib/widgets/list_filter_widget.dart	Adds “users first” toggle option to the Contacts filter popup menu.
lib/screens/map_screen.dart	Passes unread totals into `QuickSwitchBar`.
lib/screens/device_screen.dart	Passes unread totals into `QuickSwitchBar` from the device hub screen.
lib/screens/contacts_screen.dart	Introduces `_prioritizePeople` and applies people-first ordering + refactors sorting into a helper.
lib/screens/channels_screen.dart	Passes unread totals into `QuickSwitchBar`.
lib/connector/meshcore_connector.dart	Splits unread total counting into contacts vs channels for badge usage.
lib/l10n/app_en.arb	Adds the new `listFilter_usersFirst` string.
lib/l10n/app_uk.arb	Adds Ukrainian translation for `listFilter_usersFirst` and updates a few other Ukrainian strings.
lib/l10n/app_localizations.dart	Adds the new `listFilter_usersFirst` abstract getter (generated).
lib/l10n/app_localizations_en.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_bg.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_de.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_es.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_fr.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_it.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_nl.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_pl.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_pt.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_ru.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_sk.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_sl.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_sv.dart	Adds `listFilter_usersFirst` getter (generated).
lib/l10n/app_localizations_uk.dart	Adds `listFilter_usersFirst` getter + Ukrainian string updates (generated).
lib/l10n/app_localizations_zh.dart	Adds `listFilter_usersFirst` getter (generated).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

446564 · 2026-02-09T19:19:40Z

I'll take a look later today.

Clamp both _cachedContactsUnreadTotal and _cachedChannelsUnreadTotal to >= 0 after decrementing in markContactRead() and markChannelRead(). This prevents the totals from going negative if the cache drifts out-of-sync, which could cause UI badges to display incorrect values.

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ge styling

…hed contacts unread total

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

lib/connector/meshcore_connector.dart:427

The clamp upper bound here is misleading. Since you're subtracting previousCount from _cachedContactsUnreadTotal, the result will always be less than or equal to _cachedContactsUnreadTotal, making the upper bound unnecessary. Consider using max(0, _cachedContactsUnreadTotal - previousCount) instead for clarity. The same applies to line 444 for channels.

      _cachedContactsUnreadTotal = (_cachedContactsUnreadTotal - previousCount).clamp(0, _cachedContactsUnreadTotal);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

just-stuff-tm

Please resolve above mentioned issues then mark comment resolved, be sure to run dart format .and flutter analyze and resolve all issues(BEFORE COMMIT AND PUSH) as previously mentioned.
Localizations great
I like this filtering feature.

chatgpt-codex-connector · 2026-03-01T02:08:51Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

446564 · 2026-03-11T15:38:47Z

moved to draft until ready for review

446564 · 2026-04-07T15:12:34Z

@pioneer are you still planning on working on this?

pioneer · 2026-04-08T06:16:44Z

Yes, sorry, will update it very soon.

446564 · 2026-04-10T18:37:08Z

when you do, can you split out the contacts first thing, as we have filters for that and may be adding a 'chats' tab in future.

When contacts are removed in removeContact, _handleContact, or _handleContactAdvert, subtract their unread count from _cachedContactsUnreadTotal immediately so badge counts reflect the true total without waiting for a full reload.

Resolved conflicts by accepting refactored state management from main: - list_filter_widget.dart: Adopt sealed class pattern for filter actions - contacts_screen.dart: Move state to UiViewStateService instead of local setState - device_screen.dart: Accept deletion (consolidated into other screens in main) Main branch includes significant improvements: - TCP and USB transport support - Service-based state management with UiViewStateService - Translation support with message translation buttons - Signal UI consistency improvements - Additional language support (hu, ja, ko) - Comprehensive test coverage - Discovery screen refactoring

pioneer · 2026-04-21T20:17:56Z

Removed the "users on top" feature, to keep this PR clean.

446564 · 2026-04-21T20:44:07Z

I'll test this out

pioneer · 2026-04-21T20:52:04Z

Also removed Ukrainian translations, as it'd be better to have them in a separate PR.

446564 · 2026-04-21T20:55:35Z

Also removed Ukrainian translations, as it'd be better to have them in a separate PR.

ya we decided that translations from english can be skipped for submissions to dev then we can translate before release

446564 · 2026-04-21T21:03:44Z

Just missed the contacts screen, so if you are on contacts the unread badges don't show. only on channels and map. Which makes me think we should refactor that bottom nav bar into a widget at a later date.

…r the lists; fixed unread indicator wasn't on all screens

pioneer · 2026-04-21T23:08:11Z

Fixed the contacts stuff, and I thought the total unread for all chats/channels be messy, so replaced it with just a red dot. Checked from my side, so waiting for feedback.

446564 · 2026-04-22T15:52:17Z

looks better, I agree. just going to test again on linux and then read over it all

446564

lgtm, we can always make use of the actual count later or use it in other places. tested on android and linux.

zjs81 · 2026-04-30T17:06:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3c7d8e43a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-30T17:10:33Z

+    final allChannels = _channels.isNotEmpty ? _channels : _cachedChannels;
+    _cachedChannelsUnreadTotal = allChannels.fold(


Recompute unread total from current channel sync result

_recalculateCachedChannelsUnreadTotal falls back to _cachedChannels whenever _channels is empty, but _cleanupChannelSync(completed: true) now invokes this before _completeChannelSync replaces _cachedChannels with the newly synced list. If a sync result contains no non-empty channels (so _channels is empty), the total is computed from stale pre-sync cache data and the Channels tab badge can remain non-zero even after channels were cleared.

Useful? React with 👍 / 👎.

@codex how can we fix this?

Codex couldn't complete this request. Try again later.

https://claude.ai/share/3817357a-4f68-48f0-8019-106ff34950b1

pioneer added 4 commits February 9, 2026 12:56

Correct unread badges for tabs; people first contacts sort option

8668564

Merge branch 'main' into unread-peoplefirst

d0dd805

Update generated plugin registrants after merge

fd305fd

Update generated plugin registrants after merge

2bce142

Copilot AI review requested due to automatic review settings February 9, 2026 14:34

Copilot started reviewing on behalf of pioneer February 9, 2026 14:34 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Comment thread lib/connector/meshcore_connector.dart Outdated

Comment thread lib/l10n/app_en.arb Outdated

Comment thread lib/screens/contacts_screen.dart Outdated

Comment thread lib/widgets/quick_switch_bar.dart Outdated

pioneer added 2 commits February 9, 2026 17:18

Cache for unread total

c4f5c7b

"Users first" instead of "People first" everywhere

68bb031

Copilot AI review requested due to automatic review settings February 9, 2026 15:34

Copilot started reviewing on behalf of pioneer February 9, 2026 15:35 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/connector/meshcore_connector.dart

Comment thread lib/widgets/quick_switch_bar.dart Outdated

Comment thread lib/connector/meshcore_connector.dart Outdated

Proper formatting

87bcb6a

pioneer marked this pull request as draft February 10, 2026 09:19

Copilot AI review requested due to automatic review settings February 27, 2026 10:09

Copilot started reviewing on behalf of pioneer February 27, 2026 10:09 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

pioneer added 2 commits February 27, 2026 12:22

refactor: use UnreadBadge widget in QuickSwitchBar for consistent bad…

a30fc43

…ge styling

fix: filter by _shouldTrackUnreadForContactKey when recalculating cac…

c47a4cb

…hed contacts unread total

Copilot AI review requested due to automatic review settings February 27, 2026 10:29

Copilot started reviewing on behalf of pioneer February 27, 2026 10:29 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

pioneer added 3 commits February 27, 2026 12:43

Package updates from main

87b2565

Merge branch 'main' into unread-peoplefirst

ecc496f

AI translations for "Users first"

3ae1478

pioneer marked this pull request as ready for review February 27, 2026 11:00

Copilot AI review requested due to automatic review settings February 27, 2026 11:00

Copilot started reviewing on behalf of pioneer February 27, 2026 11:00 View session

just-stuff-tm reviewed Feb 28, 2026

View reviewed changes

Comment thread lib/l10n/app_en.arb Outdated

446564 marked this pull request as draft March 11, 2026 15:38

446564 added the In Progress The issue or PR is being investigated or implemented. label Apr 10, 2026

pioneer added 5 commits April 21, 2026 16:34

Run dart format and verify analyze

8611ada

Add missing users-first translations for hu/ja/ko and regen outputs

9fe4a37

Remove unused 'Users first' translation key

16ce135

pioneer changed the title ~~Unread badges for tabs; "People first" contacts sorting option~~ Unread badges for tabs Apr 21, 2026

446564 self-assigned this Apr 21, 2026

pioneer added 2 commits April 21, 2026 23:44

Restore jni to whatever is in main

d0d6a34

Reverted Ukrainian translations, will be in a separate PR

0c1e163

Red dot unread indicator in bottom tabs, keep numeric unreads only fo…

d3c7d8e

…r the lists; fixed unread indicator wasn't on all screens

pioneer marked this pull request as ready for review April 22, 2026 07:34

446564 approved these changes Apr 22, 2026

View reviewed changes

446564 removed the In Progress The issue or PR is being investigated or implemented. label Apr 30, 2026

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

		final allChannels = _channels.isNotEmpty ? _channels : _cachedChannels;
		_cachedChannelsUnreadTotal = allChannels.fold(

Conversation

pioneer commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

446564 commented Feb 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

just-stuff-tm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Mar 1, 2026

Uh oh!

446564 commented Mar 11, 2026

Uh oh!

446564 commented Apr 7, 2026

Uh oh!

pioneer commented Apr 8, 2026

Uh oh!

446564 commented Apr 10, 2026

Uh oh!

pioneer commented Apr 21, 2026

Uh oh!

446564 commented Apr 21, 2026

Uh oh!

pioneer commented Apr 21, 2026

Uh oh!

446564 commented Apr 21, 2026

Uh oh!

446564 commented Apr 21, 2026

Uh oh!

pioneer commented Apr 21, 2026

Uh oh!

446564 commented Apr 22, 2026

Uh oh!

446564 left a comment

Choose a reason for hiding this comment

Uh oh!

zjs81 commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

zjs81 Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

446564 Apr 30, 2026

Choose a reason for hiding this comment

pioneer commented Feb 9, 2026 •

edited

Loading

just-stuff-tm left a comment •

edited

Loading