feat: dynamic health status + canonical reference ranges + DB migrations #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,8 @@ import { TitleActionHeader } from '@/components/title-action-header'; | |
| import { MetricCard } from '@/components/health/metric-card'; | ||
| import { MetricSummaryCard } from '@/components/health/metric-summary-card'; | ||
| import { AnimatedEmptyState } from '@/components/animated-empty-state'; | ||
| import { formatRange } from '@/lib/health-utils'; | ||
| import { useDynamicStatus } from '@/hooks/use-dynamic-status'; | ||
| import { formatDate, formatObsValue, isDurationMetric } from '@/lib/utils'; | ||
| import { TestTubes, Droplets, Activity, Microscope, FlaskConical, Dna, Download } from 'lucide-react'; | ||
| import { Button } from '@/components/button'; | ||
|
|
@@ -18,6 +19,7 @@ function formatMetricName(code: string) { | |
| } | ||
|
|
||
| export default function LabsPage() { | ||
| const { getStatus, isAbnormal: isObsAbnormal } = useDynamicStatus(); | ||
| const { data, isLoading } = trpc.observations.list.useQuery({ limit: 200 }); | ||
| const { data: metricsData } = trpc.metrics.list.useQuery(); | ||
| const precisionMap = new Map( | ||
|
|
@@ -75,7 +77,7 @@ export default function LabsPage() { | |
| ); | ||
| const latest = sorted[0]!; | ||
| const previous = sorted[1]; | ||
| const status = getStatus(latest); | ||
| const sparkData = sorted.slice(0, 6).reverse().map((o) => o.valueNumeric ?? 0); | ||
|
|
||
| const deltaVal = | ||
|
|
@@ -131,7 +133,7 @@ export default function LabsPage() { | |
| o.unit, | ||
| o.referenceRangeLow, | ||
| o.referenceRangeHigh, | ||
| isObsAbnormal(o) ? 'Yes' : 'No', | ||
| new Date(o.observedAt).toISOString().split('T')[0], | ||
| o.category, | ||
| ]), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { useMemo } from 'react'; | ||
| import { trpc } from '@/lib/trpc/client'; | ||
| import { | ||
| deriveStatus, | ||
| isValueAbnormal, | ||
| type CanonicalRanges, | ||
| } from '@/lib/health-utils'; | ||
| import type { HealthStatus } from '@/components/health/status-badge'; | ||
|
|
||
| /** | ||
| * Hook that provides dynamic health status calculations using current optimal | ||
| * and reference ranges. Replaces static `obs.isAbnormal` and bare `deriveStatus(obs)` | ||
| * calls so that changes to ranges update the UI instantly. | ||
| */ | ||
| export function useDynamicStatus() { | ||
| const { data: metricsData, isLoading: metricsLoading } = | ||
| trpc.metrics.list.useQuery(); | ||
| const { data: optimalRangesData, isLoading: optimalLoading } = | ||
| trpc.optimalRanges.forUser.useQuery(); | ||
|
|
||
| const isLoading = metricsLoading || optimalLoading; | ||
|
|
||
| const rangesMap = useMemo(() => { | ||
| const map = new Map<string, CanonicalRanges>(); | ||
| const metricDefs = metricsData ?? []; | ||
|
|
||
| // Seed from metric definitions (reference ranges) | ||
| for (const def of metricDefs) { | ||
| map.set(def.id, { | ||
| optimalLow: optimalRangesData?.[def.id]?.rangeLow ?? null, | ||
| optimalHigh: optimalRangesData?.[def.id]?.rangeHigh ?? null, | ||
| referenceLow: def.referenceRangeLow ?? null, | ||
| referenceHigh: def.referenceRangeHigh ?? null, | ||
| }); | ||
| } | ||
|
|
||
| // Include optimal ranges for metrics not in definitions | ||
| if (optimalRangesData) { | ||
| for (const code of Object.keys(optimalRangesData)) { | ||
| if (!map.has(code)) { | ||
| map.set(code, { | ||
| optimalLow: optimalRangesData[code]?.rangeLow ?? null, | ||
| optimalHigh: optimalRangesData[code]?.rangeHigh ?? null, | ||
| referenceLow: null, | ||
| referenceHigh: null, | ||
| }); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return map; | ||
| }, [metricsData, optimalRangesData]); | ||
|
|
||
| /** Derive the display HealthStatus for an observation. */ | ||
| function getStatus(obs: { | ||
| metricCode: string; | ||
| valueNumeric?: number | null; | ||
| isAbnormal?: boolean | null; | ||
| referenceRangeLow?: number | null; | ||
| referenceRangeHigh?: number | null; | ||
| }): HealthStatus { | ||
| const ranges = rangesMap.get(obs.metricCode); | ||
| return deriveStatus(obs, ranges); | ||
| } | ||
|
|
||
| /** Check whether an observation value is abnormal (true/false/null). */ | ||
| function isAbnormal(obs: { | ||
| metricCode: string; | ||
| valueNumeric?: number | null; | ||
| isAbnormal?: boolean | null; | ||
| referenceRangeLow?: number | null; | ||
| referenceRangeHigh?: number | null; | ||
| }): boolean | null { | ||
| const ranges = rangesMap.get(obs.metricCode); | ||
| if (ranges) { | ||
| return isValueAbnormal(obs.valueNumeric, ranges); | ||
| } | ||
| // Fall back to stored value when no ranges available | ||
| return obs.isAbnormal ?? null; | ||
| } | ||
|
|
||
| /** Get the canonical ranges for a specific metric code. */ | ||
| function getRanges(metricCode: string): CanonicalRanges | undefined { | ||
| return rangesMap.get(metricCode); | ||
| } | ||
|
|
||
| return { getStatus, isAbnormal, getRanges, isLoading }; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Trash2 button fires deleteMutation.mutate directly on click with no confirmation step. The server-side delete procedure does a hard ctx.db.delete with no soft-delete or recycle bin. A single misclick irrecoverably removes a health observation. Consider adding a window.confirm or inline confirm state before triggering the mutation.