Load Bill Black #92
Merged
Load Bill Black #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may be more to do, but cre looks pretty good, at least the few I checked striprtf package may be another more robust way
some don't work anymore because of lack of RTF file and two have an unexpected dir structure
10 or so blocks are currently rejected, because of PGM notes or bumping up against something, or in one case a missing `X`
Summary so far: * "GRAVEL WALK (reel) (1), The" is missing the `X` at the beginning * "HEATHER BREEZE (reel) (a-2), The" is missing an `X` line (and no newline between it and the "a-3" version) * PGM note in s-tunes-1.txt (and 2) mentions 6/8, but the tunes above and below it are reels (it appears twice, with the same tunes surrounding it (duplicates?)) * missing newline between - 252,253 and 658,666 in c-tunes - 222,223 in d-tunes - 33,34 in e-tunes
notes: * in s-tunes 1 and 2, - there is a high number of duplicate X's - "SNOWY OWL, The" which appears 4x - 62134 is used for two tunes: "STRANGER (hornpipe), The" and "SONNY BROGAN'S JIG (a)" * is the intention to use s-tunes-2 _in place of_ s-tunes-1? * even after removing duplicate tune blocks, there are a few cases of duplicate X values in most of the files - for example, in a-tunes, 2, 3, and 5 are each used for 2 different tunes
seems to be the same except some changes related to fixing special characters like the copyright symbol
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 93.60% 94.07% +0.46%
==========================================
Files 13 15 +2
Lines 1517 1687 +170
==========================================
+ Hits 1420 1587 +167
- Misses 97 100 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for loading ABC tune data from Bill Black's Irish Traditional Tune Library (http://www.capeirish.com/ittl/). The implementation provides two approaches: the newer method using alphabetically-organized text files (bill_black.py) and the deprecated "tunefolders" method (bill_black_tunefolders.py).
Changes:
- Added
pyabc2/sources/bill_black.pymodule to load tunes from the newer alphabetical text file format - Added
pyabc2/sources/bill_black_tunefolders.pymodule for the deprecated tunefolders format - Added comprehensive tests for both modules
- Updated documentation with examples and API reference
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pyabc2/sources/bill_black.py | New module that downloads and parses ABC tunes from Bill Black's alphabetically-organized text files |
| pyabc2/sources/bill_black_tunefolders.py | New module supporting the deprecated tunefolders format with collection-based organization |
| tests/test_sources.py | Added tests for both modules including URL validation, data loading, and error handling |
| docs/examples/sources.ipynb | Added notebook example demonstrating bill_black.load_meta() usage |
| docs/api.rst | Added API documentation section for the bill_black module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
One test run case gave 403 errors for BB URLs. So note slight flakiness. Norbeck can be as well, should consider adding retries at some point, e.g. using stamina. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56