-
Notifications
You must be signed in to change notification settings - Fork 1
Load sets data and tune collections (for a certain tune) data from The Session web API #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 94.07% 94.26% +0.19%
==========================================
Files 15 15
Lines 1687 1745 +58
==========================================
+ Hits 1587 1645 +58
Misses 100 100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to load sets data and tune collections data from The Session web API. The changes enable fetching information about which collections contain a specific tune, retrieving individual member sets, and fetching all sets for a member with pagination support and multi-threading capabilities.
Changes:
- Added a generic
_consumefunction to handle paginated API endpoints with configurable multi-threading - Added
get_tune_collectionsto retrieve collection information for a specific tune - Added
get_member_setandget_member_setsto retrieve member set data with pagination support - Added comprehensive test coverage for the new API functions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| pyabc2/sources/the_session.py | Implements core API consumption logic with _consume and three new public functions for retrieving tune collections and member sets data |
| tests/test_sources.py | Adds six new test functions covering the new API functions, including validation tests and pagination scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Initial version. May later change the data structure of the returns (e.g. to include more info).
Towards #66 but doesn't implement everything discussed there (tags, etc.)