chore: Merge upstream#68
Merged
Merged
Conversation
## Summary * **What is the goal of this PR?** fixes crosspoint-reader#2132. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_
## Summary Minor cleanup flagged by newer gcc: - Removed unused variables - Removed unimplemented function declaration - `static` -> `inline` to avoid per-TU duplication --- ### AI Usage Did you use AI tools to help write this code? _**NO**_
# Conflicts: # .skills/SKILL.md # docs/sd-card-fonts.md # lib/Epub/Epub/BookMetadataCache.h # lib/I18n/translations/belarusian.yaml # lib/I18n/translations/catalan.yaml # lib/I18n/translations/czech.yaml # lib/I18n/translations/danish.yaml # lib/I18n/translations/dutch.yaml # lib/I18n/translations/english.yaml # lib/I18n/translations/finnish.yaml # lib/I18n/translations/french.yaml # lib/I18n/translations/german.yaml # lib/I18n/translations/hungarian.yaml # lib/I18n/translations/italian.yaml # lib/I18n/translations/kazakh.yaml # lib/I18n/translations/lithuanian.yaml # lib/I18n/translations/polish.yaml # lib/I18n/translations/portuguese.yaml # lib/I18n/translations/romanian.yaml # lib/I18n/translations/russian.yaml # lib/I18n/translations/slovenian.yaml # lib/I18n/translations/spanish.yaml # lib/I18n/translations/swedish.yaml # lib/I18n/translations/turkish.yaml # lib/I18n/translations/ukrainian.yaml # lib/JpegToBmpConverter/JpegToBmpConverter.cpp # lib/KOReaderSync/KOReaderCredentialStore.cpp # lib/KOReaderSync/KOReaderDocumentId.cpp # lib/PngToBmpConverter/PngToBmpConverter.cpp # lib/Serialization/Serialization.h # lib/hal/HalStorage.h # src/CrossPointSettings.cpp # src/CrossPointState.cpp # src/FontInstaller.cpp # src/RecentBooksStore.cpp # src/WifiCredentialStore.cpp # src/activities/settings/FontDownloadActivity.cpp # src/network/CrossPointWebServer.cpp # src/network/CrossPointWebServer.h # src/network/HttpDownloader.cpp # src/network/WebDAVHandler.cpp # src/network/WebDAVHandler.h # src/network/html/FilesPage.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.