fix(acme): repoint zone-exists to /api/v1/acme/zones/{zone}#16
Merged
Conversation
RcodeZero moved CheckACMEZoneExists from /api/v1/acme/{zone} to
/api/v1/acme/zones/{zone} (aligning with the sibling
/zones/{zone}/rrsets path). `rc0 acme zone-exists` was hitting the
old path and returning 404 against the live API.
Refreshes tests/fixtures/openapi.json from the live spec, rewires
the two zone-exists integration tests, and updates docstrings + the
mission-plan endpoint table. Drive-by: scripts/gen_api_coverage.py
had stale `record` verb names from before the v1.0 set/append/import
rename — corrected so regenerated docs/api-coverage.md stays current.
Closes #15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc0 acme zone-existsnow hitsGET /api/v1/acme/zones/{zone}— RcodeZero moved the endpoint there to align with the sibling/zones/{zone}/rrsets. The old/api/v1/acme/{zone}path 404s against the live API, so the command was broken in production.tests/fixtures/openapi.jsonfrom the live spec; nightly spec-drift workflow goes green and chore: OpenAPI spec drift detected (2026-05-14) #15 can close.scripts/gen_api_coverage.pystill had the pre-v1.0record add / update / replace-allverb names. Corrected toset / append / importso regenerateddocs/api-coverage.mddoesn't regress.Test plan
uv run ruff check .— cleanuv run ruff format --check .— cleanuv run mypy— cleanuv run pytest— 459 passed, 90.64% coverage (gate 88%)uv run python scripts/gen_api_coverage.py— 58/63 endpoints mapped, only intended diffCloses #15.