Skip to content

Added rpm package as part of build #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TejaswiniIBM wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Added rpm package as part of build #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0e5c922
Added rpm package as part of build
TejaswiniIBM Mar 17, 2026
993c3ea
Resolved augment comments
TejaswiniIBM Mar 23, 2026
f271bac
Resolved PR reviews in zopen-pax2rpm, pubilsh.groovy
TejaswiniIBM Mar 23, 2026
d9b16e5
Resolved PR reviews in zopen-pax2rpm
TejaswiniIBM Mar 23, 2026
5531b9b
Resolved PR comments
TejaswiniIBM Mar 26, 2026
9da910e
Fixing the review comments
TejaswiniIBM Mar 31, 2026
962d0b3
Resolved the pr review comments v2
TejaswiniIBM Mar 31, 2026
541aa2e
resolved pr comments 3
TejaswiniIBM Mar 31, 2026
057745d
versioning added
TejaswiniIBM Apr 2, 2026
edb4824
refactored the script to matchother zopen tools
TejaswiniIBM Apr 6, 2026
2fa9f22
Fixed the build errors
TejaswiniIBM Apr 6, 2026
703956e
Fixed the build issues
TejaswiniIBM Apr 6, 2026
5eb36a2
Fixed the review comments
TejaswiniIBM Apr 7, 2026
c04a514
Updated the build command to test rpm
TejaswiniIBM Apr 7, 2026
eacfd78
Changed the portbuild to portbuild test for testing the command
TejaswiniIBM Apr 7, 2026
eb99671
Fixed the test build error No compatible architectures found for build
TejaswiniIBM Apr 8, 2026
36ee648
Fixed the test build error - RPM build errors:
TejaswiniIBM Apr 8, 2026
e7315bb
Reverted the Port-Build-Test to Port-Build
TejaswiniIBM Apr 8, 2026
de65cc5
updating the branch to main
TejaswiniIBM Apr 9, 2026
a5b764f
Update publish.groovy
TejaswiniIBM Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions bin/zopen-build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ Option:
with the .rej extension.
-g, --get-source get the source and apply patch without building.
-gp, --generate-pax generate a pax.Z file based on the install contents.
-gr, --generate-rpm generate an RPM package from the pax archive.
Copy link
Copy Markdown

@augmentcode augmentcode Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also adds a top-level zopen-build file that appears as a binary/empty file in the checkout; if it’s intended as an entrypoint wrapper, it may be an accidentally committed artifact or missing content.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Copy link
Copy Markdown

@augmentcode augmentcode Bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also changes the binary zopen-diagnostics file (shown as a binary diff); please confirm this binary update is intentional and reproducible from source, not an accidentally committed artifact.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

-h, --help, -? print this information.
--no-set-active do not change the pinned version.
--no-install-deps do not install project's runtime dependencies.
Expand Down Expand Up @@ -379,6 +380,7 @@ processOptions()
buildEnvFile="./buildenv"
getSourceOnly=false
generatePax=false
generateRPM=false
setActive=true
signPax=false
forcePatchApply=false
Expand Down Expand Up @@ -476,11 +478,16 @@ processOptions()
"-gp" | "--generate-pax")
generatePax=true
;;
"-gr" | "--generate-rpm")
Copy link
Copy Markdown

@augmentcode augmentcode Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--generate-rpm currently only flips generateRPM=true, but the RPM creation logic is nested under the pax-generation flow, so using --generate-rpm by itself appears to do nothing (and won’t hit the “ensure --generate-pax” error). Consider either enforcing the pairing or making the behavior explicit to users.

Severity: medium

Other Locations
  • bin/zopen-build:2222

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

generateRPM=true
generatePax=true
;;
"-s" | "--shell")
startShell=true
;;
"-sp" | "--sign-pax")
signPax=true
generatePax=true
;;
*)
printError "Unknown option ${1} specified"
Expand Down Expand Up @@ -2310,7 +2317,25 @@ install()
if ! runAndLog "${ZOPEN_PAX_CMD}"; then
printError "Could not generate pax \"${paxFileName}\""
fi
fi

if ${generateRPM}; then
if [ -f "${paxFileName}" ]; then
printHeader "Generating RPM from ${ZOPEN_INSTALL_DIR}"
rpm_deps=$(echo "${ZOPEN_RUNTIME_DEPS}" | xargs -n1 | sort -u | xargs)
Copy link
Copy Markdown

@augmentcode augmentcode Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpm_deps is normalized via xargs -n1 | sort -u, which splits dependency expressions on whitespace; this will break versioned deps like oef >= 1.1.0 into separate tokens and can produce an invalid --requires/Requires: value in the generated spec.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

cmd="PATH=\"${ZOPEN_ROOTFS}/usr/local/bin:${PATH}\" \"${MYDIR}/zopen-pax2rpm\" \"${paxFileName}\" --summary \"${ZOPEN_NAME} package\" --build --buildroot \"${ZOPEN_ROOT}/rpmbuild\""
if [ -n "${rpm_deps}" ]; then
cmd="${cmd} --requires \"${rpm_deps}\""
fi
if ! runAndLog "${cmd}"; then
Copy link
Copy Markdown

@augmentcode augmentcode Bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/zopen-build:2233: runAndLog executes via eval, so building cmd from variables like paxFileName/ZOPEN_NAME means any unexpected shell metacharacters or quotes in those values can break the command line or be interpreted as additional shell syntax.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

printError "Could not generate RPM from \"${paxFileName}\""
fi
else
printError "Pax file ${paxFileName} not found. Ensure --generate-pax is also used."
fi
fi

if ${generatePax}; then
#TODO: Hack so that we can use coreutils md5sum without impacting builds
ZOPEN_DEPS="${ZOPEN_DEPS} coreutils jq"
if [ "${signPax}" = "true" ] && ( [ -z "${ZOPEN_GPG_SECRET_KEY_FILE}" ] || [ -z "${ZOPEN_GPG_SECRET_KEY_PASSPHRASE_FILE}" ] || [ -z "${ZOPEN_GPG_PUBLIC_KEY_FILE}" ] || [ ! -r "${ZOPEN_GPG_SECRET_KEY_FILE}" ] || [ ! -r "${ZOPEN_GPG_SECRET_KEY_PASSPHRASE_FILE}" ] || [ ! -r "${ZOPEN_GPG_PUBLIC_KEY_FILE}" ] ); then
Expand Down
Loading
Loading