Conversation
|
augment review |
🤖 Augment PR SummarySummary: Updates the zstd port to a newer upstream release and refreshes the local patch set used for z/OS builds. Changes:
Technical Notes: The patch set continues to tailor upstream build/install logic for the z/OS toolchain and environment, including platform detection and link-line library propagation. 🤖 Was this summary useful? React with 👍 or 👎 |
| #include <stdio.h> /* fprintf, fopen */ | ||
| #include <stdlib.h> /* malloc, free */ | ||
| #include <string.h> /* memset, strerror */ | ||
| +#include "platform.h" /* Large Files support, compiler specifics */ |
There was a problem hiding this comment.
platform.h is documented upstream as needing to be included first (e.g., for large-file/feature macros), but this patch moves it (and in one case util.h) after system headers in several translation units, which can cause subtle ABI/IO issues. Consider keeping these headers first (or ensuring the required macros are provided via compiler flags) to preserve the intended behavior.
Severity: medium
Other Locations
patches/assertfirst.patch:36patches/assertfirst.patch:58patches/assertfirst.patch:77patches/assertfirst.patch:95
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
No description provided.