Skip to content

update patches#26

Draft
sachintu47 wants to merge 2 commits intozopencommunity:mainfrom
sachintu47:main
Draft

update patches#26
sachintu47 wants to merge 2 commits intozopencommunity:mainfrom
sachintu47:main

Conversation

@sachintu47
Copy link
Copy Markdown
Member

No description provided.

@sachintu47
Copy link
Copy Markdown
Member Author

augment review

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Mar 24, 2026

🤖 Augment PR Summary

Summary: Updates the zstd port to a newer upstream release and refreshes the local patch set used for z/OS builds.

Changes:

  • Bumped bundled zstd version from 1.5.5 to 1.5.7 in buildenv
  • Expanded build dependencies to include additional tooling (diffutils, which)
  • Generalized .gitignore to ignore extracted zstd source directories via zstd*/
  • Removed older patch files and consolidated Makefile-related adjustments into patches/addzostomakefile.patch
  • Updated Makefile patches to recognize OS/390 and to include library variables during link steps (LIBS/LDLIBS)
  • Refreshed the tests Makefile patch to pass LDLIBS through more link commands and adjust include flag handling

Technical Notes: The patch set continues to tailor upstream build/install logic for the z/OS toolchain and environment, including platform detection and link-line library propagation.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread patches/assertfirst.patch
#include <stdio.h> /* fprintf, fopen */
#include <stdlib.h> /* malloc, free */
#include <string.h> /* memset, strerror */
+#include "platform.h" /* Large Files support, compiler specifics */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform.h is documented upstream as needing to be included first (e.g., for large-file/feature macros), but this patch moves it (and in one case util.h) after system headers in several translation units, which can cause subtle ABI/IO issues. Consider keeping these headers first (or ensuring the required macros are provided via compiler flags) to preserve the intended behavior.

Severity: medium

Other Locations
  • patches/assertfirst.patch:36
  • patches/assertfirst.patch:58
  • patches/assertfirst.patch:77
  • patches/assertfirst.patch:95

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant