Skip to content

Warn when layout="floating" is used with addon_before or addon_after#833

Open
dyve wants to merge 3 commits into
mainfrom
fix/floating-addon-warning
Open

Warn when layout="floating" is used with addon_before or addon_after#833
dyve wants to merge 3 commits into
mainfrom
fix/floating-addon-warning

Conversation

@dyve

@dyve dyve commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • layout="floating" silently has no effect when addon_before or addon_after is set — Bootstrap 5 does not support combining floating labels with input groups
  • Add a warnings.warn() so developers know their setting is being ignored rather than silently getting the wrong layout

Test plan

  • Full test suite passes (137 tests) — no existing tests exercise floating + addon, so no test changes needed

🤖 Generated with Claude Code

Floating layout silently has no effect when addons are present because
Bootstrap 5 does not support combining floating labels with input groups.
Emit a warning so developers know their layout setting is being ignored.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coveralls

coveralls commented Jun 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27939412119

Coverage increased (+0.02%) to 96.036%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 679
Covered Lines: 657
Line Coverage: 96.76%
Relevant Branches: 204
Covered Branches: 191
Branch Coverage: 93.63%
Branches in Coverage %: Yes
Coverage Strength: 14.51 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants