Open
Conversation
alxkeda
requested changes
Nov 27, 2024
Collaborator
There was a problem hiding this comment.
looks fine
- might consider changing esp_rom_delay_us to a non-blocking vtaskdelay (rtos) because it is called in an rtos task (checkbuttonpressed)
- can you rename for us the TM1637Display.cpp file to countdown.cpp or something like that since it contains the function definitions for the countdown functionality, not the lib functions for the display (and then you can also change tm1637display1 to tm1637display)
- edit chad's countdown code to use the display.start() .stop() member functions (probably not needed but for clarity)
- if its not working, you could quickly test that the pins youre using to interface with the display are working. i was having issues with pins 12/13 when i was getting the ultrasonic sensor to work. pins 2 and 16 worked for me, just make sure there is no overlap between the button input pin
- on that same note, i believe we are using pin 14 to check the button and i would create some macros for that pin so its a little clearer
- additionally, we're using 1/3 right now so i would test that they are working, can ask anthony or krish about the debugger or you can just test that things are working with the esp logging component (esp_logi(), etc.). particularly i think it would be useful to log a message to the esp monitor in vscode whenever the button is pressed, that way you can troubleshoot whether the issue is with the button or the countdown code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(only changed one component "TM1637Display1.cpp")